Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Links #3068

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Hide Links #3068

merged 1 commit into from
Mar 19, 2021

Conversation

dpatil-magento
Copy link
Contributor

@dpatil-magento dpatil-magento commented Mar 18, 2021 •
edited by supernova-at
Loading

Description

Hide links of unfinished features.

Related Issue

Closes PWA-1586.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Favorites Lists and Store Credit & Gift Cards links should not be visible in Account Menu

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@dpatil-magento dpatil-magento changed the base branch from develop to release/10.0 March 18, 2021 21:57
@PWAStudioBot
Copy link
Contributor

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 679d6f9

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 19, 2021
@dpatil-magento dpatil-magento merged commit 8408926 into release/10.0 Mar 19, 2021
@dpatil-magento dpatil-magento deleted the dev/hide-links branch March 19, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supernova-at supernova-at supernova-at approved these changes

Assignees

@supernova-at supernova-at

Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpatil-magento @PWAStudioBot @supernova-at