Add compression package as a dependency in create-pwa package. #3073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently added compression middleware as a peer dependency of
pwa-buildpack
but sincecreate-pwa
is a consumer ofpwa-buildpack
it has to have compression as a dependency in itspackage.json
.Related Issue
Closes PWA-1591
Acceptance
create-pwa
should work without failure.Verification Stakeholders
@jimbo
@dpatil-magento
Verification Steps
This can only be tested once the package is published.
yarn global remove @magento/create-pwa yarn global add @magento/create-pwa@alpha yarn global dir // to get the global directory cd GLOBAL_DIR/node_modules/@magento/create-pwa node bin/create-pwa
If you wanna test this locally, after step 4 manually change the
package.json
of thecreate-pwa
package by addingcompression: ~1.7.4
as a dependency and run ayarn install
to install the new package.Then continue with step 5.
Screenshots / Screen Captures (if appropriate)
Checklist