Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression package as a dependency in create-pwa package. #3073

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

revanth0212
Copy link
Contributor

@revanth0212 revanth0212 commented Mar 19, 2021

Description

We recently added compression middleware as a peer dependency of pwa-buildpack but since create-pwa is a consumer of pwa-buildpack it has to have compression as a dependency in its package.json.

Related Issue

Closes PWA-1591

Acceptance

create-pwa should work without failure.

Verification Stakeholders

@jimbo
@dpatil-magento

Verification Steps

This can only be tested once the package is published.

yarn global remove @magento/create-pwa
yarn global add @magento/create-pwa@alpha
yarn global dir // to get the global directory
cd GLOBAL_DIR/node_modules/@magento/create-pwa
node bin/create-pwa

If you wanna test this locally, after step 4 manually change the package.json of the create-pwa package by adding compression: ~1.7.4 as a dependency and run a yarn install to install the new package.

Then continue with step 5.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@revanth0212 revanth0212 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Mar 19, 2021
@PWAStudioBot
Copy link
Contributor

Messages
📖

Associated JIRA tickets: PWA-1591.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 736441b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:create-pwa Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants