Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1615] Scaffold DEBUG_PROJECT_CREATION does not exclude optional extension packages. #3086

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented Mar 26, 2021

Description

Steps

  1. Clone pwa-studio locally and run yarn install
  2. Run DEBUG_PROJECT_CREATION=1 packages/create-pwa/bin/create-pwa
  3. Answer all question and go to scaffolded project
  4. Run upward server

Expected - Optional extension which are not added should not be included
Actual - If you try navigate around app observe Virtual product sub-type extension, language pack etc are included

Related Issue

  • [PWA-1615] Scaffold DEBUG_PROJECT_CREATION does not exclude optional extension packages.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Run through repro steps, verify that extensions are no longer in scaffolded app using this flag

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Mar 26, 2021

Messages
📖

Associated JIRA tickets: PWA-1615.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 885c903

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 26, 2021
@larsroettig larsroettig self-requested a review April 5, 2021 15:36
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me! Albeit I had to run a different command than normal, but I think something is wrong with my local and not this PR.

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit 2eae3a1 into develop Apr 8, 2021
@sirugh sirugh deleted the tommy/scaffold-ignore-extensions branch April 26, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-concept Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants