-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-1514] Cannot place order again after initial order was declined #3091
[PWA-1514] Cannot place order again after initial order was declined #3091
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple fix. I was able to test the failure-then-success scenario by filling my cart with just enough items that the items + shipping would put it over $2000. I then placed the order, got the failure, and then set the shipping to free and tried to place the order. It worked!
I just wish we could get order details for rendering a receipt from the placeOrder
mutation instead of having to do this temp data workaround.
Oh well!
@@ -5,5 +5,4 @@ | |||
* https://devdocs.magento.com/guides/v2.3/graphql/mutations/place-order.html#errors | |||
*/ | |||
|
|||
export const PAYMENT_ERROR = | |||
'Unable to place order: Transaction has been declined. Please try again later.'; | |||
export const PAYMENT_ERROR = 'Unable to place order:'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did making this error text more generic catch a case that was being missed previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have different error message, when having order declined by sandbox using mentioned order amount, which would not trigger payment form reset. And it seems there could be more message variation starting with Unable to place order
QA Approved. |
Description
When placing an order, if the initial order is declined and cause a Checkout Error, we won't be able to try again without reloading the page.
Steps to reproduce the behavior:
In our case, we are using Braintree in sandbox mode and had an order between 2000.00 - 2999.99.
https://developers.braintreepayments.com/reference/general/testing/php#transaction-amounts
Expected behavior
We should be able to place a new order when our first try was declined.
Related Issue
Closes #3046
[PWA-1514] Cannot place order again after initial order was declined #3091
Acceptance
Verification Stakeholders
Specification
Verification Steps
In our case, we are using Braintree in sandbox mode and had an order between 2000.00 - 2999.99.
https://developers.braintreepayments.com/reference/general/testing/php#transaction-amounts
Screenshots / Screen Captures (if appropriate)
Checklist