[PWA-1016] Refactor Add To Cart to use generic AddProductsToCart mutation #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecate old mutations and methods using product specific mutations
tjwiebell
added
the
version: Minor
|
sirugh
previously approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Great job with the implementation allowing for backwards compat. I think we could even reuse this pattern where we've got un-migrated gql files.
Hopefully we actually get around to removing the deprecated code.
Approving though it seems there are tests to update and a node failure.
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
sirugh
approved these changes
Mar 31, 2021
|
QA Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Magento 2.4.1 there is a new AddProductsToCart mutation which is more generic and type agnostic than the older, type specific mutations such as "AddConfigurableProductsToCart".
Investigate whether we can replace the Simple and Configurable add mutations with the generic one. If so, please do the work as part of this ticket.
Investigate whether it can support future types such as Bundled/Virtual/etc. If so, we don't need the "Supported Product Types" logic anymore, so please remove that too.
Links:
https://i.gyazo.com/5e19a2e43a1b46654d053197a280c1ca.png
#2769 (comment)
https://github.com/magento/pwa-studio/blob/develop/packages/peregrine/lib/talons/ProductFullDetail/useProductFullDetail.js#L237-L262
Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist