-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] #3102 Create a new Target for EditModal and Summary #3103
[FEATURE] #3102 Create a new Target for EditModal and Summary #3103
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback left! Please make sure the propTypes
are all correct :)
packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/editCard.css
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/summary.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/braintreeSummary.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/editCard.js
Outdated
Show resolved
Hide resolved
packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/summary.js
Outdated
Show resolved
Hide resolved
@anthoula I did some tree analyses today, change some imports to lazy and try analyses if we have any rendering problem |
@larsroettig Thank you for looking into this. Your new changes improved the warning - went from 2.9s to 2.5s. We will open up a follow-up ticket to address the warning, and not hold up this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, lazy is so easy :)
...venia-ui/lib/components/CheckoutPage/PaymentInformation/__tests__/paymentInformation.spec.js
Outdated
Show resolved
Hide resolved
…on/__tests__/paymentInformation.spec.js Co-authored-by: Stephen <sirugh@users.noreply.github.com>
…-studio into 3102newTargetEditPayment
✅ QA approved |
Description
This Pull request allows used to move Braintree in a separated extension also allows third party developers
to create fully integrated payment methods
Breaking Changes in This PR
Related Issue
Closes #3102
Acceptance
Verification Stakeholders
@sirugh
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist