Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser back buttons isn't responsive on Search Page #3119

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Fix browser back buttons isn't responsive on Search Page #3119

merged 3 commits into from
Apr 15, 2021

Conversation

huykon
Copy link
Contributor

@huykon huykon commented Apr 14, 2021

Description

Check for #3118 for explanation.

Related Issue

Closes #3118.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to https://develop.pwa-venia.com/default/search.html?query=tops+dress&page=1
  2. Add some filters
  3. Now click on the browser back button once
  4. You should see we're back to the prev page/state.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Apr 14, 2021 •
edited
Loading

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 72ce12c

@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Apr 14, 2021
@anthoula anthoula self-assigned this Apr 14, 2021
@anthoula
Copy link
Contributor

Good catch. This looks good. Added some additional test coverage. Thank you

@dpatil-magento dpatil-magento merged commit 9383ae7 into magento:develop Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthoula anthoula anthoula approved these changes

Assignees

@anthoula anthoula

Labels
pkg:peregrine Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: browser back buttons isn't responsive on Search Page
4 participants
@huykon @PWAStudioBot @anthoula @dpatil-magento