Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-1564: [bug]: Guest checkout, France region validation failed #3133

Merged
merged 5 commits into from
Apr 26, 2021

Conversation

anthoula
Copy link
Contributor

@anthoula anthoula commented Apr 19, 2021

Description

Some region codes are inconsistent across countries. Update region field to use region_id instead of region_code to help fix inconsistencies in GraphQL response.

Related Issue

Closes #3057

Related Pull Requests

Acceptance

Verification Stakeholders

@dpatil-magento

Specification

Verification Steps

  1. Go to the checkout as guest with a valid cart
  2. Set the address country with 'France'
  3. Set the region with 'Ain' (the first one)
  4. Fill all the required fields as usual
  5. Click on "Continue to Shipping Method" button
  6. Select Shipping Method
  7. Click on "Continue to Payment Information" button
  8. Enter required payment information
  9. Ensure a France billing address is selected
  10. Click on "Review Order"
  11. Click on "Place Order"
  12. An order is successfully placed

Additional scenarios outlined in PWA-1564

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Apr 19, 2021

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against ad72dd2

@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Apr 19, 2021
- fix existing tests
- allow numeric region id in Region component
- update snaps
@@ -63,6 +65,7 @@ export const GET_SHIPPING_ADDRESS = gql`
city
region {
code
region_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need label for this one?

supernova-at
supernova-at previously approved these changes Apr 22, 2021
Copy link
Contributor

@supernova-at supernova-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, verification steps passed ✅

@supernova-at
Copy link
Contributor

During code review / demo, @anthoula pointed out that we should add editing / initial value testing to the verification / QA steps

@tjwiebell
Copy link
Contributor

@anthoula
All manual test cases pass and original bug is no longer reproducible. This did unfortunately break an MFTF test, CartPageRegisteredUserCheckout.

Screen Shot 2021-04-23 at 4 09 40 PM

I debugged a little, and it appears this selector is no longer unique after your change, [class*='select-input-'][name*='region[region_id]']. I'm not sure if Dev blocked merging based on failures and would just fix them in post, but happy to resolve this failure for you if you're not ramped up on the test suite yet. Ping me on Slack and we'll decide how to proceed.

@sirugh sirugh deleted the PWA-1564 branch April 26, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: Adobe Summit Hackathon pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Guest checkout, France region validation failed
5 participants