-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA-1564: [bug]: Guest checkout, France region validation failed #3133
Conversation
- Use region_id instead of region_code
|
- fix existing tests - allow numeric region id in Region component - update snaps
- fix existing tests
@@ -63,6 +65,7 @@ export const GET_SHIPPING_ADDRESS = gql` | |||
city | |||
region { | |||
code | |||
region_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need label
for this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, verification steps passed ✅
- fix existing tests, mock form state
During code review / demo, @anthoula pointed out that we should add editing / initial value testing to the verification / QA steps |
@anthoula I debugged a little, and it appears this selector is no longer unique after your change, |
Description
Some region codes are inconsistent across countries. Update region field to use region_id instead of region_code to help fix inconsistencies in GraphQL response.
Related Issue
Closes #3057
Related Pull Requests
Acceptance
Verification Stakeholders
@dpatil-magento
Specification
Verification Steps
Additional scenarios outlined in PWA-1564
Screenshots / Screen Captures (if appropriate)
Checklist