-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-1598] Add product to Cart from the wishlist #3170
Conversation
# Conflicts: # packages/peregrine/lib/talons/WishlistPage/useWishlistItem.js
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work - not much to comment on here, though I did notice something off with the images (or at least one product's images). You'll also want to remedy the query validator failure. Also the view-specific talon props are an interesting pattern and I'd be interested to hear the team's take on it.
packages/peregrine/lib/talons/AddToCartDialog/useAddToCartDialog.js
Outdated
Show resolved
Hide resolved
packages/peregrine/lib/talons/AddToCartDialog/useAddToCartDialog.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
QA Approved. |
* Complete out of stock styling included in scope * Restore configurable product support when product is fully configured. * Get variant display mostly working on option selection * Finish add to cart mutation * Get dynamic pricing to work * Remove stock status message and add spacing to CTA * Fix graphql validation errors and start adding some docs * Add FormError and loading indicator * Adjust indicator style to be more reusable outside of header * Center indicator in header * Fix clipping of icon on tablet/mobile viewports * Fix existing failing tests * Cover new code with tests Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Description
As a customer I want to add a wish-listed product to the cart so that I can buy a product that I saved for later earlier
Preconditions
Acceptance Criteria
Test Plan
Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist