Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1598] Add product to Cart from the wishlist #3170

Merged
merged 15 commits into from
May 25, 2021

Conversation

tjwiebell
Copy link
Contributor

@tjwiebell tjwiebell commented May 7, 2021

Description

As a customer I want to add a wish-listed product to the cart so that I can buy a product that I saved for later earlier

Preconditions

  • Wishlist is enabled in Magento Admin Panel>Stores > Settings > Configuration > Customers > Wish List
  • Multi-wishlist is enabled in Stores > Settings > Configuration > Customers > Wish List>Enable Multiple Wish Lists (EE)
  • User is logged in to Venia and opens My Account>Favorites
  • User has products favorited

Acceptance Criteria

  • User sees an option to add product to cart for each product in the wishlist. If configurable product is in the wishlist, user sees the option to configure it and add to the cart.
  • User selects adding product to the cart, cart gets updated and products stays in the favorite list. If user chooses to add the same product to the cart, product quantity gets updated.
  • If product in the favorites is out of stock, user sees an indication of that, no option to add it wishlist available.

Test Plan

  1. Add a Simple item to wishlist
  2. Verify that you can add the simple item to the cart successfully without having to select any options
  3. Verify that the item also remains in the wishlist
  4. Add a configurable item with options selected to wishlist
  5. Verify that you can add the configurable item to the cart successfully (have to confirm option selections?)
  6. Verify that the item also remains in the wishlist
  7. Add a configurable item with no options selected to wishlist
  8. Verify that you can add the item to the cart successfully, having to first select item options via a dialog
  9. Verify that the dialog works on mobile
  10. Verify that the item remains in the wishlist after being added to cart
  11. Mark one of the wishlist items as out of stock in the Magento Admin
  12. Verify that the item's "Add to Cart" button is disabled. It should be visually different (grayed out), and not clickable

Related Issue

  • [PWA-1598] Add product to Cart from the wishlist

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. See Test Plan

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented May 7, 2021

Messages
📖

Associated JIRA tickets: PWA-1598.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b1ca5e4

@tjwiebell tjwiebell added the version: Minor This changeset includes functionality added in a backwards compatible manner. label May 10, 2021
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - not much to comment on here, though I did notice something off with the images (or at least one product's images). You'll also want to remedy the query validator failure. Also the view-specific talon props are an interesting pattern and I'd be interested to hear the team's take on it.

sirugh
sirugh previously approved these changes May 18, 2021
sirugh
sirugh previously approved these changes May 18, 2021
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit 888b9ba into develop May 25, 2021
@dpatil-magento dpatil-magento deleted the tommy/atc-from-wishlist branch May 25, 2021 15:03
revanth0212 pushed a commit that referenced this pull request May 25, 2021
* Complete out of stock styling included in scope

* Restore configurable product support when product is fully configured.

* Get variant display mostly working on option selection

* Finish add to cart mutation

* Get dynamic pricing to work

* Remove stock status message and add spacing to CTA

* Fix graphql validation errors and start adding some docs

* Add FormError and loading indicator

* Adjust indicator style to be more reusable outside of header

* Center indicator in header

* Fix clipping of icon on tablet/mobile viewports

* Fix existing failing tests

* Cover new code with tests

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants