Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1719] Filter model close icon and drop down arrows are not visible. (Actually present but not visible) #3171

Merged
merged 3 commits into from
May 12, 2021

Conversation

tjwiebell
Copy link
Contributor

Description

URL - https://develop.pwa-venia.com/

Steps -

  1. Go to Category or Search page
  2. Open Filter model and observe

Expected - All icons should be visible
Actual - Close X and dropdown Arrow icons are not visible

https://i.gyazo.com/7fa41e3b0607f92aebec833693fa333d.gif

Related Issue

  • [PWA-1719] Filter model close icon and drop down arrows are not visible. (Actually present but not visible)

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Open filter modal, verify icons are visible

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented May 7, 2021

Messages
📖

Associated JIRA tickets: PWA-1719.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against faf369f

@tjwiebell tjwiebell added the version: Patch This changeset includes backwards compatible bug fixes. label May 10, 2021
@anthoula
Copy link
Contributor

QA approved

@anthoula anthoula merged commit 7b26f0c into develop May 12, 2021
@tjwiebell tjwiebell deleted the tommy/fix-filter-stroke branch February 1, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants