-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB Banner UI test #3178
PB Banner UI test #3178
Conversation
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section. |
venia-integration-tests/src/tests/pageBuilder/integrationTests/banner.spec.js
Outdated
Show resolved
Hide resolved
failureThresholdType: 'percent' | ||
}); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}); | |
}); | |
Just for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look fine but some clean-up is needed on the assertions end.
@@ -0,0 +1,7 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need this any more. We moved these to custom Cypress actions in the wishlist PR.
* @param {String} accountEmail accountEmail to createAccount | ||
* @param {String} accountPassword accountPassword to createAccount | ||
*/ | ||
export const createAccount = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need these any more. We moved these to custom cypress actions. Or am I missing something?
.click(); | ||
}; | ||
|
||
export const assertCreateAccount = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move assertions to assertions folder.
* Utility function to assert empty wishlist | ||
* @param {String} wishlistHeaderText wishlist page header text | ||
*/ | ||
export const assertWishlistHeading = wishlistHeaderText => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move assertions to the assertions folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont know how I ended up here but updated all, thanks. Please re-check :)
Will merge after checks pass! Re-verified, had to clear local cypress chrome cache. |
Description
TODO: Describe your changes in detail here.
Related Issue
Closes https://jira.corp.magento.com/browse/PWA-1540.
Acceptance
Verification Stakeholders
Specification
Verification Steps
banner.spec.js
should passSteps -
Go to venia-integration-test dir
Run
yarn install
Run
yarn test
Run
banner.spec.js
from cypress uiScreenshots / Screen Captures (if appropriate)
Checklist