-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Always show a wishlist name and do not show visibility toggle if only one list #3184
Conversation
|
Signed-off-by: sirugh <rugh@adobe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a question I had about using a talon instead, the code looks fine. Nice work buddy.
<Wishlist | ||
key={wishlist.id} | ||
data={wishlist} | ||
shouldRenderVisibilityToggle={wishlists.length > 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it merit if we create and send it over from the talon instead? By doing so we are opening up the component to have custom definitions for shouldRenderVisibilityToggle
. In the default case, it will be wishlists.length > 1
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds good.
There are some test failures. Check it out dude. |
Signed-off-by: sirugh <rugh@adobe.com>
Description
Related Issue
Closes PWA-1742.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures (if appropriate)
Checklist