You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In a venia store with venia sample data, go to any product with colour variants
2. Click on the default colour variant (matches the colour of the selected product's default carousel thumbnails).
3. Click on an alternative colour, then click on the default colour again, repeat this
4. Duplicate thumbnails for the default colour variant will be produced
In the console react will warn that it has detected duplicate key props in the thumbnail list
Expected behavior
Should be no duplicate keys in the carousel's thumbnail list.
carousel thumbnail keys are not currently unique based on item file + label
item IDs are unique (within a products variants) so should be a good fix
Changes
Change ProductImageCarousel Thumbnail key to unique id
Refer to magento#3185 for reproducing the bug
* Change ProductImageCarousel Thumbnail key to unique id
* carousel thumbnail keys are not currently unique based on item file + label
* item IDs are unique (within a products variants) so should be a good fix
DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
Though I wasn't able to repro the reported bug, I do believe this solution is better than what we had previously. uid is exactly the field we should be using for key, as it is meant to be unique per item within a list. I don't mind approving this and moving it forward.
Yeah there must be some difference in the way the pwa-studio tutorial sets up venia versus how your CI sets up venia. I'm not sure how to see that though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
tjwiebell
added
the
version: Patch
Fix for #3185
Description
carousel thumbnail keys are not currently unique based on item file + label
item IDs are unique (within a products variants) so should be a good fix
Changes
Related Issue
Closes #3185
Verification Steps
Screenshots / Screen Captures