Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] strip line comments when importing graphql files #3196

Merged
merged 2 commits into from
Jun 10, 2021
Merged

[bugfix] strip line comments when importing graphql files #3196

merged 2 commits into from
Jun 10, 2021

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented May 27, 2021 •
edited by supernova-at
Loading

Description

See thread in issue #3190

Related Issue

Closes PWA-1799.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. yarn test should pass.
  2. yarn build should work.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@sirugh sirugh changed the title strip line comments when importing graphql files [bugfix] strip line comments when importing graphql files May 27, 2021
@sirugh sirugh mentioned this pull request May 27, 2021
Closed
8 tasks
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented May 27, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-1799.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against a66c890

larsroettig
larsroettig approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Code Review

@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label May 27, 2021
@supernova-at supernova-at merged commit 3a75ac6 into develop Jun 10, 2021
@supernova-at supernova-at deleted the fix-no-comment-build-gql branch June 10, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsroettig larsroettig larsroettig approved these changes

@eug123 eug123 eug123 approved these changes

Assignees

@larsroettig larsroettig

@eug123 eug123

Labels
pkg:pwa-buildpack Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sirugh @PWAStudioBot @larsroettig @eug123 @supernova-at