Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove the extension from venia concept by default #3215

Merged
merged 4 commits into from
Jun 9, 2021
Merged

fix: Remove the extension from venia concept by default #3215

merged 4 commits into from
Jun 9, 2021

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented Jun 3, 2021

Description

ACDL may break if it is double loaded. Some downstream dependencies might auto load it so we should remove the default inclusion of the extension. I have also provided guidance for future use.

Related Issue

Closes PWA-1815.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Scaffold an app from this branch.
  2. Ensure that the ACDL extension is not auto included.

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@sirugh sirugh added the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Jun 3, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 3, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-1815.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 2a7deb7

@anthoula anthoula removed the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Jun 7, 2021
@eug123 eug123 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jun 9, 2021
@eug123
Copy link
Contributor

eug123 commented Jun 9, 2021 •
edited
Loading

  • Scaffold an app from this branch.
  • Ensure that the ACDL extension is not auto included.

Verification steps passed

@eug123 eug123 merged commit 611d70e into develop Jun 9, 2021
@michaelyu0123 michaelyu0123 deleted the no-acdl-ext branch February 1, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimbo jimbo jimbo approved these changes

Assignees

@jimbo jimbo

Labels
pkg:extensions pkg:venia-concept Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sirugh @PWAStudioBot @eug123 @jimbo @anthoula @revanth0212