Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mega menu when pathname is undefined #3230

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

LucasCalazans
Copy link
Member

@LucasCalazans LucasCalazans commented Jun 10, 2021

Description

Fixing an error when the user goes to /undefined route.

The useMegaMenu talon was understanding that is the default category, causing the error

Related Issue

Closes #3192.

Acceptance

Verification Steps

  • Access this route /undefined
  • The store should show a not found page with no error

Verification Stakeholders

Specification

Test Plan

  • Access this route /undefined
  • The store should show a not found page

Test scenario(s) for direct fix/feature

  • Access this route /undefined
  • The store should show a not found page

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

No

Any ad-hoc/edge case scenarios that need to be considered?

No

Screenshots / Screen Captures

image

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 10, 2021

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 822f90a

@supernova-at
Copy link
Contributor

supernova-at commented Jul 2, 2021

QA

📝 In progress

  • MFTF
  • Cypress
  • Test Plan / Verification Steps
  • Lighthouse
  • Alternate Browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: unhandled edgecase for path "/undefined"
6 participants