Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve watch script #325

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Improve watch script #325

merged 2 commits into from
Oct 10, 2018

Conversation

zetlen
Copy link
Contributor

@zetlen zetlen commented Oct 4, 2018

This PR is a:

[ ] New feature
[x] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

The current npm run watch:all script is too slow, heavy, and intensive, and it doesn't work without running a build first. This is an enhanced experience driven by a script:

When this pull request is merged, this will become the npm run watch:all experience.

@zetlen zetlen added enhancement New feature or request 2.x release labels Oct 4, 2018
@zetlen zetlen force-pushed the zetlen/improve-watch-script branch from 1fcba43 to 2bf2b7c Compare October 4, 2018 09:38
@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 15.984% when pulling 98f2573 on zetlen/improve-watch-script into 449c52c on release/2.0.

mhhansen
mhhansen previously approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@mhhansen mhhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested PR on top of my local release/2.0, works OK 👍

enhancement: improve watch script
78c99d5 
fix:(upward): detect and handle exceptions
@zetlen zetlen force-pushed the zetlen/improve-watch-script branch from c7f1f92 to 78c99d5 Compare October 9, 2018 23:14
@zetlen zetlen merged commit 4e9a2d4 into release/2.0 Oct 10, 2018
@zetlen zetlen deleted the zetlen/improve-watch-script branch October 10, 2018 07:35
@sharkySharks sharkySharks mentioned this pull request Nov 28, 2023
Open
@sharkySharks sharkySharks mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhhansen mhhansen mhhansen left review comments

@Crifen Crifen Awaiting requested review from Crifen

@jimbo jimbo Awaiting requested review from jimbo

@JStein92 JStein92 Awaiting requested review from JStein92

@pcvonz pcvonz Awaiting requested review from pcvonz

@Serunde Serunde Awaiting requested review from Serunde

@shakyShane shakyShane Awaiting requested review from shakyShane

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zetlen @coveralls @mhhansen