-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix region error braintree #3251
Merged
supernova-at
merged 9 commits into
magento:develop
from
larsroettig:fix-region-error-braintree
Jul 2, 2021
Merged
Fix region error braintree #3251
supernova-at
merged 9 commits into
magento:develop
from
larsroettig:fix-region-error-braintree
Jul 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anthoula
reviewed
Jun 28, 2021
packages/peregrine/lib/talons/CheckoutPage/ShippingInformation/AddressForm/useGuestForm.js
Outdated
Show resolved
Hide resolved
- Roll back change to useGuestForm
anthoula
approved these changes
Jun 29, 2021
QA📝 In Progress
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Partner: TechDivision
partners-contribution
pkg:peregrine
Progress: done
version: Minor
This changeset includes functionality added in a backwards compatible manner.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When shipping information is set to a UK address, a region error is displayed within the Braintree Payment section, after clicking "Review Order"
Variable "$region" got invalid value null; Expected non-nullable type String! not to be null.
https://develop.pwa-venia.com/
https://venia.magento.com/
Steps to reproduce
Add item to cart (develop.pwa-venia.com)
Go to checkout
Enter UK address for Shipping Information
Set any Shipping method
Enter credit card (Braintree) info, and check Billing address same as shipping
Click "Review Order"
Form error message displays
Able to review, and place order
Related Issue
Closes PWA-1823
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test Plan
Test scenario(s) for direct fix/feature
Example
Test scenario(s) for any existing impacted features/areas
Example
Test scenario(s) for any Magento Backend Supported Configurations
Example
Is Browser/Device testing needed?
Example
Any ad-hoc/edge case scenarios that need to be considered?
Example
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist