Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix region error braintree #3251

Merged

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented Jun 24, 2021

Description

When shipping information is set to a UK address, a region error is displayed within the Braintree Payment section, after clicking "Review Order"

Variable "$region" got invalid value null; Expected non-nullable type String! not to be null.

https://develop.pwa-venia.com/
https://venia.magento.com/

Steps to reproduce

Add item to cart (develop.pwa-venia.com)
Go to checkout
Enter UK address for Shipping Information
Set any Shipping method
Enter credit card (Braintree) info, and check Billing address same as shipping
Click "Review Order"
Form error message displays
Able to review, and place order

Related Issue

Closes PWA-1823

Acceptance

  • Able to complete checkout with UK, France, and US addresses.
  • Check with different shipping and billing addresses
  • Update MFTF test to account for UK address

Verification Stakeholders

Specification

Verification Steps

Test Plan

Test scenario(s) for direct fix/feature

Example

  • Verify user is able to apply filters on category page
  • Verify user is able to apply filters on search page

Test scenario(s) for any existing impacted features/areas

Example

  • Verify user is able to sort data after applying filters on category page
  • Verify user is able to sort data after applying filters on search page

Test scenario(s) for any Magento Backend Supported Configurations

Example

  • Update default Sort value in backend and repeat above scenarios

Is Browser/Device testing needed?

Example

  • Yes, browser testing is needed as X UI component may be impacted on
  • Yes, device testing is needed as X UI component may be impacted on <mobile|desktop|etc>

Any ad-hoc/edge case scenarios that need to be considered?

Example

  • Apply all filters to get 0 results and then remove filters to see respective products

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 24, 2021

Messages
📖

Associated JIRA tickets: PWA-1823.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against fd240e6

@larsroettig larsroettig requested a review from anthoula June 28, 2021 16:04
@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jun 28, 2021
- Roll back change to useGuestForm
@supernova-at
Copy link
Contributor

supernova-at commented Jul 1, 2021

QA

📝 In Progress

  • MFTF
  • Cypress
  • Test Plan
  • Lighthouse
  • Alternate Browsers

@supernova-at supernova-at merged commit d978770 into magento:develop Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: TechDivision partners-contribution pkg:peregrine Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants