Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-1734: Configure staging and production responses to be gzipped #3255

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

anthoula
Copy link
Contributor

@anthoula anthoula commented Jun 28, 2021

Description

Compress HTML responses with gzip

Related Issue

Closes PWA-1734.

Acceptance

HTML is gzipped for staging and production

Verification Stakeholders

Specification

Verification Steps

Test Plan

Test scenario(s) for direct fix/feature

  • Verify that the network request for your HTML file (ex: 'venia.magento.com') has a Response Header called "content-encoding" whose value is set to "gzip".

Test scenario(s) for any existing impacted features/areas

  • n/a

Test scenario(s) for any Magento Backend Supported Configurations

  • n/a

Is Browser/Device testing needed?

  • No, just verify correct compression is used in the developer tools

Any ad-hoc/edge case scenarios that need to be considered?

  • No

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

- update cache-control to force caching and gzip
@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jun 28, 2021
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 28, 2021

Messages
📖

Associated JIRA tickets: PWA-1734.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 1e39b08

Copy link
Contributor

@revanth0212 revanth0212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks straightforward but how can I verify this?

@revanth0212
Copy link
Contributor

Working 👏

image

Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ QA aprrove

@revanth0212 revanth0212 merged commit b447eab into magento:develop Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants