Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari browser has a bug related to the INTL NumberFormat polyfill. We are already handling it in the code but unfortunately, we are throwing an error as well. Since an error is thrown the whole app crashes on Safari instead of rendering the app with the handled logic.
This PR simply changes the function to not throw and warn instead to let the backup logic do its magic and render the app.
magento.pwa-venia.com
develop.pwa-venia.com
After Fix
Related Issue
Closes PWA-1894
Acceptance
App should render properly on Safari.
Verification Stakeholders
@eug123
@tjwiebell
Verification Steps
Is Browser/Device testing needed?
Yes, Browser testing is needed.
Breaking Changes (if any)
None
Checklist