Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing phase name in Venia Webpack config error message #331

Merged
merged 5 commits into from
Oct 8, 2018
Merged

Missing phase name in Venia Webpack config error message #331

merged 5 commits into from
Oct 8, 2018

Conversation

Igloczek
Copy link
Contributor

@Igloczek Igloczek commented Oct 5, 2018

This PR is a:

Enhancement/Optimization

Summary

Adding missing phase name in Venia Webpack config error message

@PWAStudioBot
Copy link
Contributor

Fails
🚫

The following file(s) were not formatted with prettier. Make sure to execute npm run prettier locally prior to committing.

packages/venia-concept/webpack.config.js

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Oct 5, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 19.379% when pulling b1ca24e on Igloczek:missing-error-details into 652b221 on magento-research:release/2.0.

@zetlen zetlen self-requested a review October 8, 2018 12:21
zetlen
zetlen approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, thanks.

@zetlen zetlen merged commit 9fcfcee into magento:release/2.0 Oct 8, 2018
@sharkySharks sharkySharks mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetlen zetlen zetlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Igloczek @PWAStudioBot @coveralls @zetlen