-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA-1880: Add tailwind #3341
Merged
mikhaelbois
merged 17 commits into
magento:develop
from
larsroettig:PWA-1880-tailwindcss
Aug 27, 2021
Merged
PWA-1880: Add tailwind #3341
mikhaelbois
merged 17 commits into
magento:develop
from
larsroettig:PWA-1880-tailwindcss
Aug 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jimbo
suggested changes
Aug 16, 2021
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
Aug 16, 2021
Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com>
Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com>
Please fix the lint errors mentioned in the danger comment. |
fooman
reviewed
Aug 25, 2021
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
Aug 25, 2021
eug123
added
the
version: Major
This changeset includes incompatible API changes and its release necessitates a Major version bump.
label
Aug 26, 2021
eug123
approved these changes
Aug 26, 2021
jimbo
approved these changes
Aug 26, 2021
✅ QA
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Partner: TechDivision
partners-contribution
pkg:pwa-buildpack
pkg:venia-concept
Progress: done
version: Major
This changeset includes incompatible API changes and its release necessitates a Major version bump.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
tailwindcss
and its dependencies to the appropriatepackage.json
files within PWA Studio's monorepoRelated Issue
Closes PWA-1880
Acceptance
Acceptance Criteria
tailwindcss
and its dependencies to the appropriatepackage.json
files within PWA Studio's monorepopostcss-loader
for CSS filespostcss.config.js
file tovenia-concept
and ensures it gets scaffoldedtailwind.config.js
file tovenia-concept
and ensures it gets scaffoldedVerification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist