Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-1880: Add tailwind #3341

Merged
merged 17 commits into from
Aug 27, 2021
Merged

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented Aug 11, 2021

Description

Adds tailwindcss and its dependencies to the appropriate package.json files within PWA Studio's monorepo

Related Issue

Closes PWA-1880

Acceptance

Acceptance Criteria

  • Adds tailwindcss and its dependencies to the appropriate package.json files within PWA Studio's monorepo
  • Updates our default Webpack configuration to include postcss-loader for CSS files
  • Adds a postcss.config.js file to venia-concept and ensures it gets scaffolded
  • Adds a tailwind.config.js file to venia-concept and ensures it gets scaffolded
  • Includes the following properties in the Tailwind config file, based on the POC examples [app, theme]:
  • mode
  • presets
  • purge
  • separator

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Aug 11, 2021

Messages
📖

Associated JIRA tickets: PWA-1880.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 02f12c8

packages/venia-concept/tailwind.config.js Outdated Show resolved Hide resolved
packages/venia-concept/tailwind.config.js Outdated Show resolved Hide resolved
packages/venia-concept/postcss.config.js Show resolved Hide resolved
Lars Roettig and others added 5 commits August 17, 2021 13:32
Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com>
Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com>
@larsroettig larsroettig marked this pull request as ready for review August 17, 2021 13:57
@revanth0212
Copy link
Contributor

Please fix the lint errors mentioned in the danger comment.

@larsroettig larsroettig requested a review from jimbo August 20, 2021 07:45
@eug123 eug123 added the version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. label Aug 26, 2021
@mikhaelbois
Copy link
Contributor

✅ QA

  • ✅ Build
  • ✅ Scaffolding + Build
  • ✅ Tests (Unit + Integration)
  • ✅ Storybook

@mikhaelbois mikhaelbois merged commit 033f18a into magento:develop Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: TechDivision partners-contribution pkg:pwa-buildpack pkg:venia-concept Progress: done version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants