Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of redux dev tools #348

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Add support of redux dev tools #348

merged 2 commits into from
Oct 11, 2018

Conversation

Starotitorov
Copy link
Contributor

This PR is a:

[ ] New feature
[x] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

Additional information

I guess we need to log only in development mode.

@magento-cicd2
Copy link

magento-cicd2 commented Oct 10, 2018

CLA assistant check
All committers have signed the CLA.

@PWAStudioBot
Copy link
Contributor

Fails
🚫

The following file(s) were not formatted with prettier. Make sure to execute npm run prettier locally prior to committing.

packages/peregrine/src/store/composeEnhancers.js
packages/peregrine/src/store/index.js
packages/peregrine/src/store/middleware/index.js
🚫

The following file(s) did not pass ESLint. Execute npm run lint locally for more details

packages/peregrine/src/store/index.js

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Oct 10, 2018

Coverage Status

Coverage decreased (-0.04%) to 15.944% when pulling a98707e on Starotitorov:feature/add-support-of-redux-dev-tools into 4e9a2d4 on magento-research:release/2.0.

@zetlen
Copy link
Contributor

zetlen commented Oct 11, 2018

Excellent additions. Thank you for catching the issue with logging in production.

@zetlen zetlen self-requested a review October 11, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants