Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 2172: Validate Shopping Cart Promotions are displayed correctly #3609

Merged
merged 26 commits into from
Feb 25, 2022

Conversation

michaelyu0123
Copy link
Contributor

Description

As a merchant I want to be able to personalize promotions through segmentation so that I can provide the best possible experience to my customers

Acceptance Criteria

Shopping cart price rules should be applied to relevant carts accurately
Cart price rules based on segmentation must reflect the accurate customer segment
Display Shopping Cart Price Rule Label in cart summary

Example Scenarios

Free Shipping > $50 cart total, no exclusions
Free Shipping for Registered Customers only - registered customer segment applied to rule
10% Discount over $500 Cart value for Guest Customers - guest customer segment applied to rule, not applicable for registered users
15% Discount over $500 Cart value for Registered Customers - registered customer segment applied to rule, not applicable for registered users
20% Discount for high spending customers - registered customer segment, total historical order value > $1000

Related Issue

Closes #Pwa 2172

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test Plan
Execute -

Verify cart price rules are displayed based on how they are configured in backend.
Verify all scenarios from the example.
Verify Merge cart flow from guest to registered user where guest cart has some rule applied and registered user cart has something different.
Test Coverage -

Add cypress integration test coverage.

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

hwyu@adobe.com added 3 commits December 9, 2021 14:38
- Updated discountSummary and price summary allows individual discount dropdown
- Added test coverage for feature
- Updated discountSummary and price summary allows individual discount dropdown
- Added test coverage for feature
@michaelyu0123 michaelyu0123 added the version: Patch This changeset includes backwards compatible bug fixes. label Dec 9, 2021
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 9, 2021

Messages
📖

Associated JIRA tickets: PWA-2172.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 135b399

hwyu@adobe.com and others added 2 commits December 10, 2021 15:24
- Added dropdown animation
- Updated tests
- Updated discount summary styles
@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 24, 2022

Successfully started codebuild job for the following test suites:

pr-test
scaffold-pwa
cypress

@michaelyu0123
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 24, 2022

Successfully started codebuild job for cypress

@michaelyu0123
Copy link
Contributor Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 24, 2022

Successfully started codebuild job for cypress

Copy link
Contributor

@ericeoeur ericeoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved, Ready for QA

@mikhaelbois
Copy link
Contributor

mikhaelbois commented Feb 25, 2022

@michaelyu0123

  • Free Shipping > $50 cart total, no exclusions ✅
    The free shipping is applied.
    Found this issue with the Table Rate that did not show the right price compared to Luma.
    But this can be checked in another task.

image

image

  • Free Shipping for Registered Customers only ✅
  • 10% Discount over $500 Cart value for Guest Customers ✅
  • 15% Discount over $500 Cart value for Registered Customers ✅
  • 20% Discount for high spending customers ✅

@mikhaelbois
Copy link
Contributor

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 25, 2022

Successfully started codebuild job for the following test suites:

pr-test
scaffold-pwa
cypress

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 25, 2022

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • verify block content:
    • Error: Image was 2.038771010526952% different from saved snapshot with 131212.04020389778 different pixels. See diff for details: /venia-integration-tests/src/snapshots/integrationTests/pageBuilder/block.spec.js/__diff_output__/Page-Builder-Block-Page.diff.png
  • should apply mediaQuery styles:
    • CypressError: `cy.visit()` failed trying to load:

      https://pr-3609.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-3609.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify tabs content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-3609.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-3609.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
      ,should apply mediaQuery styles:
      • CypressError: cy.visit() failed trying to load:

      https://pr-3609.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-3609.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify text content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-3609.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-3609.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify video content alignment:
      • CypressError: cy.visit() failed trying to load:

      https://pr-3609.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-3609.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • user should be able to add and remove products from wishlist:
      • CypressError: cy.visit() failed trying to load:

      https://pr-3609.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-3609.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 135b399

@mikhaelbois
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 25, 2022

Successfully started codebuild job for cypress

Copy link
Contributor

@ericeoeur ericeoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved✅

@mikhaelbois
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 25, 2022

Successfully started codebuild job for cypress

@mikhaelbois
Copy link
Contributor

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented Feb 25, 2022

Successfully started codebuild job for the following test suites:

pr-test
scaffold-pwa
cypress

@mikhaelbois mikhaelbois merged commit 5b87fec into develop Feb 25, 2022
@dpatil-magento dpatil-magento deleted the PWA-2172 branch February 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants