Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cypress results logging #3613

Merged
merged 14 commits into from
Jan 14, 2022
Merged

Conversation

revanth0212
Copy link
Contributor

@revanth0212 revanth0212 commented Dec 10, 2021

Description

When we added parallelization of cypress tests one of the cons was inability to see all the test results as a single unit at the end. This was because when a user decides to parallelize cypress tests, there will be n number of cypress threads and they wont be talking to each other to aggregate results at the end.

With this PR, we have added a new feature that will aggregate all the results and present them at the end in a readable tabular format. This functionality adds features to not only report the statues of all the tests but also aggregates the errors if any and prints them in red to catch the user's eye.

In case of all passes:

image

If something fails:

image

Related Issue

Closes PWA-2453

Verification Stakeholders

@dpatil-magento

Verification Steps

Run cypress tests as is and you should see results at the end.

yarn test:headless -t 4 --url https://develop.pwa-venia.com/

@revanth0212 revanth0212 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Dec 10, 2021
@revanth0212 revanth0212 changed the title Revanth/cypress error logging Better cypress results logging Dec 10, 2021
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 10, 2021

Messages
📖

Associated JIRA tickets: PWA-2453.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 6f879db

Copy link
Contributor

@pedrochiossi pedrochiossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ericeoeur
Copy link
Contributor

After multiple QA attempts, there were several errors including Webpack Compilation Errors and test hanging when attempting to connect to the browser. @revanth0212 @pedrochiossi

image

@dpatil-magento dpatil-magento force-pushed the revanth/cypress-error-logging branch from c973ad5 to 6f879db Compare January 13, 2022 20:40
@ericeoeur
Copy link
Contributor

All looking good on the QA side-- will be merging momentarily.

@ericeoeur ericeoeur merged commit 9872825 into develop Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants