-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better cypress results logging #3613
Conversation
|
…gento/pwa-studio into revanth/cypress-error-logging
- Updated logic for threadcount greater than test. - Modified script to process exit instead. - Updated display to show summary at bottom.
…a-studio into revanth/cypress-error-logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
After multiple QA attempts, there were several errors including Webpack Compilation Errors and test hanging when attempting to connect to the browser. @revanth0212 @pedrochiossi |
c973ad5
to
6f879db
Compare
All looking good on the QA side-- will be merging momentarily. |
Description
When we added parallelization of cypress tests one of the cons was inability to see all the test results as a single unit at the end. This was because when a user decides to parallelize cypress tests, there will be
n
number of cypress threads and they wont be talking to each other to aggregate results at the end.With this PR, we have added a new feature that will aggregate all the results and present them at the end in a readable tabular format. This functionality adds features to not only report the statues of all the tests but also aggregates the errors if any and prints them in red to catch the user's eye.
In case of all passes:
If something fails:
Related Issue
Closes PWA-2453
Verification Stakeholders
@dpatil-magento
Verification Steps
Run cypress tests as is and you should see results at the end.
yarn test:headless -t 4 --url https://develop.pwa-venia.com/