[PWA-2498] Rename Link's prefetchType prop #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@magento create issue from PR |
jeremycharron
changed the title
jeremycharron
added
the
version: Minor
There was a problem hiding this comment.
@jimbo
Code looks good except single comment about TODO. I added a minor version label + fixed the "closes issue" in description. Warning should be gone next checks run.
| */ | ||
| const Link = props => { | ||
| const talonProps = useLink(props); | ||
| // TODO: remove `prefetchType` |
There was a problem hiding this comment.
Should this TODO be removed?
There was a problem hiding this comment.
No, the prop still exists so as not to be a breaking change. We can actually remove it in a future major release, and delete the comment at that time.
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
jeremycharron
approved these changes
Jan 24, 2022
|
QA has passed for this ticket and will be merged momentarily. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the
Linkcomponent, rename the boolean propprefetchTypetoshouldPrefetch. The former appears to indicate it will contain a type rather than a boolean, causing some confusion. The approach hereinprefetchTypeprop toLinkanduseLink, but does not remove itshouldPrefetchas a new prop to both component and talonprefetchTypeunless it istrueRelated Issue
Closes #3647
Acceptance
Verification Stakeholders
Specification
Verification Steps
Links with either value of
prefetchTypeshould work the same as they do now. That said, we don't appear to have any.Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
These changes should be non-breaking. Eventually, we should remove the deprecated prop, which would be a breaking change.
Checklist
Resolved issues: