Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in component import name; consolidate import #3648

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Fix typo in component import name; consolidate import #3648

merged 3 commits into from
Aug 26, 2022

Conversation

JesseMaxwell
Copy link
Contributor

@JesseMaxwell JesseMaxwell commented Jan 13, 2022 •
edited by m2-assistant bot
Loading

Verification Steps

  1. Navigate to a category.
  2. Make sure "Add to Cart" button exists.
  3. Click "Add to Cart" button.

Description

This fixes two nitpicks:

  • The button in the import was inconsistent with both the file name and component.
  • Going up to the parent directory and back down is inconsistent and unnecessary.

Resolved issues:

  1. resolves [Issue] Fix typo in component import name; consolidate import #3719: Fix typo in component import name; consolidate import

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 13, 2022 •
edited
Loading

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 191c2de

@anthoula
Copy link
Contributor

@magento create issue from PR

@m2-assistant m2-assistant bot mentioned this pull request Feb 28, 2022
Closed
@anthoula anthoula added the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Feb 28, 2022
@anthoula anthoula removed the needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA label Jul 25, 2022
jcalcaben
jcalcaben previously approved these changes Aug 26, 2022
View reviewed changes
@jcalcaben jcalcaben added version: Patch This changeset includes backwards compatible bug fixes. Progress: ready for review and removed Progress: approved labels Aug 26, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 26, 2022

Successfully started codebuild job for cypress

@dpatil-magento dpatil-magento merged commit 0026c62 into magento:develop Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpatil-magento dpatil-magento dpatil-magento approved these changes

@jcalcaben jcalcaben jcalcaben left review comments

Assignees

@jcalcaben jcalcaben

@dpatil-magento dpatil-magento

Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix typo in component import name; consolidate import
5 participants
@JesseMaxwell @pwa-studio-bot @anthoula @dpatil-magento @jcalcaben