-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-2227] Use sample data with personalized content #3670
[PWA-2227] Use sample data with personalized content #3670
Conversation
…69-dynamic-blocks
…69-dynamic-blocks
…69-dynamic-blocks
…69-dynamic-blocks
…2227-use-sample-data-with-personalized-content
…rsonalized-content
…69-dynamic-blocks
…2227-use-sample-data-with-personalized-content
|
packages/venia-ui/lib/components/CartPage/PriceSummary/discountSummary.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but perhaps should look into removing the js injected inline styling so we don't have to use important!
…rsonalized-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rsonalized-content
Some Cypress tests are failing because some images are not loading properly. |
…rsonalized-content
…rsonalized-content
Description
Front-end part for new personalized content module that generates dynamic blocks and cart rule related to a customer segment
Add discount price label in the cart + add styles for dynamic blocks banner on homepage
Test / Demo environment : https://jeremycharron-o4saqja-4txwfa4z2sor6.eu-4.magentosite.cloud/
Back-end pull-requests : https://github.com/magento-commerce/venia-sample-data-modules/pull/19 and https://github.com/magento-commerce/venia-sample-data-modules-ee/pull/2
Related Issue
Closes PWA-2227
Acceptance
Verification Stakeholders
Project maintainers
Specification
N/A
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Yes (Chrome, Safari, Firefox, Edge) + mobile
Any ad-hoc/edge case scenarios that need to be considered?
Make sure that wysiwyg/welcome-back background images are being created in /pub directory
Screenshots / Screen Captures (if appropriate)
On PWA Front-End (you need
jcharron/PWA-2227-use-sample-data-with-personalized-content
on front-end) :Breaking Changes (if any)
No breaking change
Checklist