Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-2227] Use sample data with personalized content #3670

Merged

Conversation

jeremycharron
Copy link
Contributor

@jeremycharron jeremycharron commented Jan 27, 2022

Description

Front-end part for new personalized content module that generates dynamic blocks and cart rule related to a customer segment
Add discount price label in the cart + add styles for dynamic blocks banner on homepage

Test / Demo environment : https://jeremycharron-o4saqja-4txwfa4z2sor6.eu-4.magentosite.cloud/
Back-end pull-requests : https://github.com/magento-commerce/venia-sample-data-modules/pull/19 and https://github.com/magento-commerce/venia-sample-data-modules-ee/pull/2

Related Issue

Closes PWA-2227

Acceptance

Verification Stakeholders

Project maintainers

Specification

N/A

Verification Steps

Test scenario(s) for direct fix/feature

  1. As a guest, verify that "Get Connected" black banner is displayed on the homepage
  2. As a guest, add an item to cart and verify that LOYAL10 coupon code cannot be applied in cart.
  3. Log in as sharon@example.com sample user and verify that "Welcome back" blue banner is displayed on the homepage
  4. As Sharon, verify that "Get Connected" banner is not displayed on homepage
  5. As Sharon, verify that LOYAL10 coupon code can be applied in cart and gives 10% off order
  6. After testing step 5, verify that discount label is "Frequent Shopper 10% discount"
  7. Try to install new sample data on fresh Adobe Commerce environment
  8. Verify that new dynamic blocks, customer segments and cart rule are editable in Admin panel.

Test scenario(s) for any existing impacted features/areas

  1. Verify that setup:upgrade is working and not generating any error

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Yes (Chrome, Safari, Firefox, Edge) + mobile

Any ad-hoc/edge case scenarios that need to be considered?

Make sure that wysiwyg/welcome-back background images are being created in /pub directory

Screenshots / Screen Captures (if appropriate)

On PWA Front-End (you need jcharron/PWA-2227-use-sample-data-with-personalized-content on front-end) :
black-blue
black-banner

Breaking Changes (if any)

No breaking change

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

mikhaelbois and others added 22 commits November 29, 2021 14:11
…2227-use-sample-data-with-personalized-content
…2227-use-sample-data-with-personalized-content
@jeremycharron jeremycharron added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jan 27, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 27, 2022

Messages
📖

Associated JIRA tickets: PWA-2227.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 135bec2

Copy link
Contributor

@michaelyu0123 michaelyu0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps should look into removing the js injected inline styling so we don't have to use important!

Copy link
Contributor

@michaelyu0123 michaelyu0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikhaelbois
Copy link
Contributor

Some Cypress tests are failing because some images are not loading properly.
But this is not linked to the updates made here.
QA ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants