Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1950] Fix click target for long spanning tabs #3676

Merged

Conversation

jeremycharron
Copy link
Contributor

@jeremycharron jeremycharron commented Jan 28, 2022

Description

When scrolling in a long list of tabs from the pagebuilder and clicking on a tab at the end, the target was inconsistent, moving back the scroll and focusing on another tab.
This PR fixes the click target accuracy.

Environment with fix and CMS content : https://jeremycharron-o4saqja-4txwfa4z2sor6.eu-4.magentosite.cloud/tabs

For easier testing :

  • Decrease the width of your window to be able to scroll
  • Replicating can be tricky, so try on dev or prod first

Related Issue

Closes PWA-1950

Acceptance

Verification Stakeholders

Project maintainers

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  1. In a CMS page with 20 tabs or more, scroll on the right with keyboard arrows and make sure that click target is accurate for all tabs

Test scenario(s) for any existing impacted features/areas

  1. Verify that drag and drop works properly on desktop and on touch device

Test scenario(s) for any Magento Backend Supported Configurations

N/A

Is Browser/Device testing needed?

Yes, browser testing is needed on Chrome, Safari, Firefox, Edge
Yes, device testing is needed on both desktop and touch device.

Any ad-hoc/edge case scenarios that need to be considered?

No

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

No breaking change

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@jeremycharron jeremycharron added the version: Patch This changeset includes backwards compatible bug fixes. label Jan 28, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 28, 2022

Messages
📖

Associated JIRA tickets: PWA-1950.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 0700bf5

Copy link
Contributor

@mikhaelbois mikhaelbois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@mikhaelbois
Copy link
Contributor

QA ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants