Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-2575] Wishlist page error when configured variant added #3703

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

mikhaelbois
Copy link
Contributor

@mikhaelbois mikhaelbois commented Feb 14, 2022

…ishlist

Description

ConfigurableWishlistItem cannot get configurable_product_option_uid and configurable_product_option_value_uid until fix planned for 2.4.5.
This fix will use the previous way to get the options data by using id and value_id instead.

Related Issue

Closes https://jira.corp.magento.com/browse/PWA-2575.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  • Add Simple Product on "Favorites List" from Catalog Page.
  • Add Configurable Product on "Favorites List" from Catalog Page.
  • Add Simple Product on "Favorites List" from Product Detail Page.
  • Add Configurable Product on "Favorites List" from Product Detail Page.
  • Go to Favorites List Page and validate products are there.
  • Remove products from list.
  • Move products from list to cart and vice-versa.
  • Test multiple wishlist feature.
  • Run updated Cypress test venia-integration-tests/src/tests/e2eTests/wishList/singleWishlistAddRemoveProduct.spec.js.

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@mikhaelbois mikhaelbois added version: Minor This changeset includes functionality added in a backwards compatible manner. and removed Progress: ready for review labels Feb 14, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 14, 2022

Messages
📖

Associated JIRA tickets: PWA-2575.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against dff7aa2

Copy link
Contributor

@pedrochiossi pedrochiossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@ericeoeur
Copy link
Contributor

✅ QA Passed for this ticket and will be merging shortly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants