-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect order confirmation page to Redux #371
Merged
Starotitorov
merged 3 commits into
magento:feature/order-confirmation-page
from
Starotitorov:feature/order-confirmation-connect
Oct 22, 2018
Merged
Connect order confirmation page to Redux #371
Starotitorov
merged 3 commits into
magento:feature/order-confirmation-page
from
Starotitorov:feature/order-confirmation-connect
Oct 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starotitorov
added a commit
that referenced
this pull request
Oct 30, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 8, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 9, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 12, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 13, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 13, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 13, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 14, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 14, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 15, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 15, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 15, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Starotitorov
added a commit
that referenced
this pull request
Nov 16, 2018
* Connect order confirmation page to Redux * Add tests to checkoutReceipt redux domain * Add handle create account test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[x] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
Implement separate redux domain for checkout receipt. Connect order confirmation page component to redux.
Additional information
I think it is better to have separate domain for each checkout steps, this will help in future to implement separate pages for each step easily if we need this. This pull request provides an example of how to organize project by feature.