Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-2610: Update Magento capability table #3724

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

michaelyu0123
Copy link
Contributor

Adds 12.3.0 entry in compatibility table

Closes https://jira.corp.magento.com/browse/PWA-2610

- Updated magento-compatibility.js to include 12.3.0 to core 2.4.4
@michaelyu0123 michaelyu0123 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Feb 28, 2022
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 28, 2022

Fails
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖

Associated JIRA tickets: PWA-2610.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against c9ffd25

anthoula
anthoula previously approved these changes Mar 1, 2022
- Updated magento-compatibility.js to include 12.3.0 to core 2.4.3
@michaelyu0123
Copy link
Contributor Author

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 2, 2022

Successfully started codebuild job for the following test suites:

scaffold-pwa
cypress
lighthouse-desktop
lighthouse-mobile
pr-test

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 2, 2022

Fails
🚫

node failed.

🚫 Lighthouse assertions failed 😔. All assertions must pass before this PR can be merged
https://pr-3724.pwa-venia.com/

Largest Contentful Paint (maxNumericValue)

  • Expected: 2500
  • Actual: 5618.289229934692
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-largest-contentful-paint/

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 470
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-max-potential-fid/

First Contentful Paint (maxNumericValue)

  • Expected: 1800
  • Actual: 2739.718
  • Result: Failed
  • Docs link: https://web.dev/first-contentful-paint/
https://pr-3724.pwa-venia.com/venia-tops.html?page=1

Largest Contentful Paint (maxNumericValue)

  • Expected: 2500
  • Actual: 5286.576
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-largest-contentful-paint/

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 470
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-max-potential-fid/

First Contentful Paint (maxNumericValue)

  • Expected: 1800
  • Actual: 2740.374
  • Result: Failed
  • Docs link: https://web.dev/first-contentful-paint/
https://pr-3724.pwa-venia.com/valeria-two-layer-tank.html

Largest Contentful Paint (maxNumericValue)

  • Expected: 2500
  • Actual: 5349.914999999999
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-largest-contentful-paint/

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 471
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-max-potential-fid/

First Contentful Paint (maxNumericValue)

  • Expected: 1800
  • Actual: 3005.915
  • Result: Failed
  • Docs link: https://web.dev/first-contentful-paint/
https://pr-3724.pwa-venia.com/search.html?query=tops&page=1

Largest Contentful Paint (maxNumericValue)

  • Expected: 2500
  • Actual: 4532.638
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-largest-contentful-paint/

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 472
  • Result: Failed
  • Docs link: https://web.dev/lighthouse-max-potential-fid/

First Contentful Paint (maxNumericValue)

  • Expected: 1800
  • Actual: 2733.432
  • Result: Failed
  • Docs link: https://web.dev/first-contentful-paint/

Log

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c9ffd25

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 2, 2022

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • verify block content:
    • Error: Image was 1.8583289491183264% different from saved snapshot with 119599.0778389369 different pixels. See diff for details: /venia-integration-tests/src/snapshots/integrationTests/pageBuilder/block.spec.js/__diff_output__/Page-Builder-Block-Page.diff.png

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against c9ffd25

@michaelyu0123
Copy link
Contributor Author

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 2, 2022

Successfully started codebuild job for the following test suites:

scaffold-pwa
cypress
lighthouse-desktop
lighthouse-mobile
pr-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants