You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several places throughout the app that still query for a deprecated price field that does not reflect discounted pricing in Shared Catalogs
Actual Behavior:
when product price is adjusted with a sales promotion (special price, % discount on catalog etc) it's not reflected on the storefront
Original product price is displayed, not a discounted one
Expected behavior:
Discounted price is displayed in the catalog (not the original one)
No price discount indication on the storefront (part of PWA-1117)
Related Issue
Closes [PWA-2672] Product prices is informed by the outdated field
Create a simple product A and configurable product A with special price.
Create a simple product B and configurable product B with special price only for logged in customer group only.
Setup a catalog price rule as mentioned in wiki for particular date range across storefront
Execute -
Go to Venia store front and verify products show proper prices as per pre-conditions on -
search results
Search suggestion
Category page
Product details page
Mini cart
Cart page
Edit product card on cart page
Checkout
Order confirmation
Order history
Wishlist
Verify on store view 1 and 2 both.
Add special price product to cart and try applying coupon code, gift cards and place order.
Precondition setup -
Setup a catalog price rule as mentioned in wiki for particular date range across storefront but only for selected products.
Execute -
Go to Venia store front and verify products show proper prices as per pre-conditions and all pages mentioned in above scenario as applicable
Cypress Test coverage
NO ui change so expecting all changes to be covered in unit and/or api functional test. If at all needed there is discount summary cypress integration test which can be updated.
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.
DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖
Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
tjwiebell
added
version: Major
This changeset includes incompatible API changes and its release necessitates a Major version bump.
and removed
version: Patch
This changeset includes backwards compatible bug fixes.
labels
Apr 14, 2022
@tjwiebell Please check this failing cypess test. Its throwing error toast. Same works on develop (checked locally).
NOTE - Other failing cypress test reported above is not related to this pr, you can ignore that one.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tjwiebell
added
the
version: Patch
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Description
Several places throughout the app that still query for a deprecated price field that does not reflect discounted pricing in Shared Catalogs
Actual Behavior:
when product price is adjusted with a sales promotion (special price, % discount on catalog etc) it's not reflected on the storefront
Original product price is displayed, not a discounted one
Expected behavior:
Discounted price is displayed in the catalog (not the original one)
No price discount indication on the storefront (part of PWA-1117)
Related Issue
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test Plan
Wiki - https://docs.magento.com/user-guide/catalog/product-price-special.html
Precondition setup -
Create a simple product A and configurable product A with special price.
Create a simple product B and configurable product B with special price only for logged in customer group only.
Setup a catalog price rule as mentioned in wiki for particular date range across storefront
Execute -
Go to Venia store front and verify products show proper prices as per pre-conditions on -
search results
Search suggestion
Category page
Product details page
Mini cart
Cart page
Edit product card on cart page
Checkout
Order confirmation
Order history
Wishlist
Verify on store view 1 and 2 both.
Add special price product to cart and try applying coupon code, gift cards and place order.
Precondition setup -
Setup a catalog price rule as mentioned in wiki for particular date range across storefront but only for selected products.
Execute -
Go to Venia store front and verify products show proper prices as per pre-conditions and all pages mentioned in above scenario as applicable
Cypress Test coverage
NO ui change so expecting all changes to be covered in unit and/or api functional test. If at all needed there is discount summary cypress integration test which can be updated.
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist