AC-2790::No visual indication of focus on buttons. #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@magento create issue from PR |
anthoula
added
the
version: Patch
anthoula
previously approved these changes
Sep 20, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
run pr-deploy |
|
Successfully started codebuild job for |
|
run cypress |
|
Successfully started codebuild job for |
|
@glo82145 Fix does focus Next Page (>), Previous Page (<), First Page (<<)and Last Page (>>) buttons but it still lacking to focus page numbers (1, 2) |
|
run cypress |
|
Successfully started codebuild job for |
|
run lighthouse-desktop |
|
Successfully started codebuild job for |
|
run lighthouse-mobile |
|
Successfully started codebuild job for |
|
QA Approved. |
anthoula
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
No visual indication of focus on buttons.
Environment
Adobe Magento - LUMA
Context
Windows 10; Chrome 88;
Reproduction Steps
Locations (representative sample):
Search Results
Sub-Category landing page
Mini Cart
Checkout - Shipping
Checkout - Review & Payments
My Account
For close button:
Actual Behavior
There is no visual indication of keyboard focus when using TAB or SHIFT+TAB to navigate through controls of the website. Examples include:
Module 02 - Search Results:
Page selection buttons (which includes Next ">" and Previous "<")
Close button "X" on dialogs
Module 03 - Sub-Category landing page:
Page selection buttons (which includes Next ">" and Previous "<")
Close button "X" on dialogs
Module 05a - Mini Cart:
Close button "X" on dialog
Module 06a - Checkout - Shipping:
Close button "X" on "Sign In" dialog
Module 06b - Checkout - Review & Payments:
Close button "X" on "Sign In" dialog
Module 08 - My Account:
Close button "X" on dialog
Keyboard-only users can become disoriented when focus is not indicated.
Expected Behavior
Ensure that when actionable elements receive focus, that it appears on screen and that a visible focus indicator is present.
Related Issue
Closes https://jira.corp.magento.com/browse/AC-2790
Closes https://jira.corp.adobe.com/browse/PWA-2972
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: