Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-2489::Page title for search page not informative (Search Results) #3931

Merged
merged 10 commits into from
Nov 9, 2022

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Aug 10, 2022

Description

Reproduction Steps
search "short" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

  1. Execute a site search and observe the page title in the browser tab.

Actual Behavior
The search page does not have a descriptive title; its title is "Default Store View". When the page <title> of the document does not describe the topic or purpose of the page, users of assistive technology may have trouble finding content or orienting themselves.

Expected Behavior
Ensure that the value for the <title> element is updated as the page content changes and describes the page's purpose or topic in a concise matter (e.g. "Search Results -

Related Issue

Closes #https://jira.corp.adobe.com/browse/AC-2489

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. resolves [Issue] AC-2489::Page title for search page not informative (Search Results) #3940: AC-2489::Page title for search page not informative (Search Results)

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 10, 2022

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: AC-2489.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against f31c337

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Aug 16, 2022

Successfully started codebuild job for lighthouse-desktop

@anthoula
Copy link
Contributor

@magento create issue from PR

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 8, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against f31c337

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 9, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 9, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento
Copy link
Contributor

QA Approved

@dpatil-magento dpatil-magento merged commit 8184525 into magento:develop Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] AC-2489::Page title for search page not informative (Search Results)
4 participants