-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-2492::Missing visual text label for buttons #3952
Conversation
|
@magento create issue from PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the tests to use the new attributeLabel
values so that the snapshots don't say things like undefined's option red
run cypress |
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests
|
run lighthouse-desktop |
Successfully started codebuild job for |
run lighthouse-mobile |
Successfully started codebuild job for |
QA Approved. |
Description
Reproduction Steps
select "Blouses & Shirts" > select "Susanna Draped Tank" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]
Actual Behavior
There are no visual text labels for "Fashion Color" buttons.
When no visual labels (text or image labels) and/or instructions are provided for input, users with visual or cognitive disabilities may not know what a field is for.
Expected Behavior
Provide text labels that are always visible to indicate the purpose of each button.
Related Issue
Closes #AC-2492.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: