Move devdocs to package root, simplify scripts #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2018 12:04
Confirmed with @jcalcabemn that pwa-devdocs should not have its dependencies versioned along with the rest of the Studio. This helps us because it has external dependencies and defines a "build" script, so every Lerna command had to specifically exclude it. Now our Lerna scripts can be simpler. Moved and audited package deps to compensate for change.
jcalcaben
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation
[x] Other: organizational chore
Summary
When this pull request is merged, it will move devdocs to root to simplify scripts.
Confirmed with @jcalcaben that pwa-devdocs should not have its
dependencies versioned along with the rest of the Studio.
This helps us because it has external dependencies and defines a "build"
script, so every Lerna command had to specifically exclude it. Now our
Lerna scripts can be simpler.
Moved and audited package deps to compensate for change.