Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-6679::The button is not usable by keyboard #3980

Merged
merged 6 commits into from
Nov 16, 2022

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Oct 17, 2022

Description

TODO:

Environment https://venia.magento.com/
Testing Method Observation
Resolution Desktop
Page Checkout
Location/Component Place Order button
Issue description The button is not usable by keyboard
Additional Note
Criteria Name 2.1.1 Keyboard
Level A
Impact Blocker
Category Visual, Motor, Cognitive
Responsibility Developer
Fix (YES/NO) Y
Fix Date  

Related Issue

Closes #AC-6679.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. resolves [Issue] AC-6679::The button is not usable by keyboard #3997: AC-6679::The button is not usable by keyboard

Sorry, something went wrong.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 17, 2022

Fails
🚫 A version label is required. A maintainer must add one.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: AC-6679.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b914c2c

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@anthoula
Copy link
Contributor

@magento create issue from PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
jcalcaben
jcalcaben previously approved these changes Nov 15, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 16, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against b914c2c

@dpatil-magento
Copy link
Contributor

dpatil-magento commented Nov 16, 2022

QA Approved. @jcalcaben Can you please check and approve b914c2c , it was causing unit test build failure.

@jcalcaben jcalcaben added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] AC-6679::The button is not usable by keyboard
5 participants