Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3052::Page Builder column-line content type is not supported, thi… #4028

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Jan 6, 2023

…s content will not be rendered

Description

Add support for Page Builder column-line content type

Related Issue

Closes #3949 .

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 6, 2023

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 0e6f61b

@anthoula anthoula added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jan 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@glo42707
Copy link
Contributor

glo42707 commented Mar 6, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 6, 2023

Successfully started codebuild job for lighthouse-desktop

@glo42707
Copy link
Contributor

glo42707 commented Mar 6, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 6, 2023

Successfully started codebuild job for lighthouse-mobile

@glo42707
Copy link
Contributor

glo42707 commented Mar 6, 2023

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 6, 2023

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to remove an item from the cart:
    • AssertionError: Timed out retrying after 30000ms: expected '[ , 1 more... ]' to contain 4
  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected <span.discountSummary-discountLineItemLabel-LrJ.priceSummary-lineItemLabel-1Cs.justify-self-start.my-2.grid.grid-flow-col.items-center> not to exist in the DOM, but it was continuously found.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 0e6f61b

@glo42707
Copy link
Contributor

glo42707 commented Mar 7, 2023

QA Approved By @juhi kumari based on jira ticket https://jira.corp.adobe.com/browse/PWA-3085

@glo42707 glo42707 merged commit 72a2627 into magento:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Page Builder column-line content type is not supported, this content will not be rendered.
5 participants