Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG#-3064 When the button cancel beside create account is pressed by … #4049

Merged
merged 9 commits into from
Mar 23, 2023

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

…the keyboard, nothing happens

Description

Pre-Conditions:

Have Magento 2.4.6alpha2 EE setup with Venia configured.
Make sure Venia has at least one customer login account to login into the Venia front end.
Make sure Screen reader installed and enabled.
Steps to Reproduce:

Open Venia front end in any browser
Navigate by using tab button sign in button > press enter to expand
Navigate to create account button > without filling details > tab to cancel button and press enter to cancel.

Expected result: Cancel button should respond with the cancel functionality in UI when the ENTER key is pressed

Actual result: Cancel button is not working with the keyboard, when the ENTER key is pressed

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3064.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Feb 28, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3064.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 194cd80

glo82145
glo82145 previously approved these changes Mar 2, 2023
@glo42707
Copy link
Contributor

glo42707 commented Mar 6, 2023

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 6, 2023

Successfully started codebuild job for cypress

@glo42707
Copy link
Contributor

glo42707 commented Mar 6, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 6, 2023

Successfully started codebuild job for lighthouse-desktop

@glo42707
Copy link
Contributor

glo42707 commented Mar 6, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 6, 2023

Successfully started codebuild job for lighthouse-mobile

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 6, 2023

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found.
  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 194cd80

@glo42707
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 16, 2023

Successfully started codebuild job for cypress

PWA-3064:: When the button "cancel" beside create account is pressed by the keyboard, nothing happens.
@glo42707
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for cypress

@glo42707
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-desktop

@glo42707
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 6bfcd87 into magento:develop Mar 23, 2023
@RaghavendraTirumalasetti RaghavendraTirumalasetti added the version: Patch This changeset includes backwards compatible bug fixes. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants