Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG##PWA-3063 No proper screen reader announcements are for the optio… #4066

Merged
merged 7 commits into from
Mar 24, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Mar 23, 2023

…ns related to size

Description

Pre-Conditions:

Have Magento 2.4.6alpha2 EE setup with Venia configured.
Make sure Venia has at least one customer login account to login into the Venia front end.
Make sure Screen reader installed and enabled.
Steps to Reproduce:

Open Venia front end in any browser
Navigate by using tab button > go tops > select any product like carina cardigan
On pressing tab it should navigate to the fashion size using screen reader enabled
click and select a particular size

Expected result:

On pressing tab and selecting any size it should announce as Fashion size L button
If we select the size, then the announcement should be as Fashion size L button selected
Actual result:

On pressing tab and selecting any size it is announcing as L button
Even after selecting L size, it just says L button

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3063.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 23, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3063.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 516a51c

@glo82145 glo82145 changed the title Pwa 3063 BUG##PWA-3063 No proper screen reader announcements are for the optio… Mar 23, 2023
@glo82145
Copy link
Collaborator Author

run cypress

@glo82145 glo82145 closed this Mar 23, 2023
@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for cypress

@glo82145
Copy link
Collaborator Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for cypress

@glo82145
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator Author

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 23, 2023

Successfully started codebuild job for lighthouse-mobile

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 23, 2023

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to add and remove promotions from cart:
    • AssertionError: Timed out retrying after 30000ms: Expected not to exist in the DOM, but it was continuously found.
  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 516a51c

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 24, 2023

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 24, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator Author

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Mar 24, 2023

Successfully started codebuild job for cypress

@glo82145 glo82145 merged commit 1e420d3 into magento:develop Mar 24, 2023
@RaghavendraTirumalasetti RaghavendraTirumalasetti added the accessibility Accessibility improvements based on WCAG 2.0 standards. label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility improvements based on WCAG 2.0 standards. pkg:venia-ui Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants