Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3080:: When you click on Thumbnail, Add to cart works #4102

Merged
merged 3 commits into from
May 16, 2023
Merged

PWA-3080:: When you click on Thumbnail, Add to cart works #4102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6252fed
PWA-3080:: When you click on Thumbnail, Add to cart works
Tarun50745 Apr 25, 2023
403d562
PWA-3080:: updated test cases
Tarun50745 Apr 25, 2023
35e41e2
Merge branch 'develop' into PWA-3080
glo82145 May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...enia-ui/lib/components/ProductImageCarousel/__tests__/__snapshots__/carousel.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
aria-label="Current Image"
className="rootSelected"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down Expand Up @@ -294,6 +295,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
aria-label="Next Image"
className="root"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down Expand Up @@ -344,6 +346,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
aria-label="Next Image"
className="root"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down Expand Up @@ -394,6 +397,7 @@ exports[`renders the Carousel component correctly w/ sorted images 1`] = `
aria-label="Next Image"
className="root"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down
3 changes: 3 additions & 0 deletions ...nia-ui/lib/components/ProductImageCarousel/__tests__/__snapshots__/thumbnail.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ exports[`renders root class if not the active Thumbnail 1`] = `
aria-label="Next Image"
className="root"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down Expand Up @@ -58,6 +59,7 @@ exports[`renders the Thumbnail component correctly 1`] = `
aria-label="Current Image"
className="rootSelected"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down Expand Up @@ -111,6 +113,7 @@ exports[`renders transparent placeholder when no file name is provided 1`] = `
aria-label="Current Image"
className="rootSelected"
onClick={[Function]}
type="button"
>
<div
className="root container"
Expand Down
1 change: 1 addition & 0 deletions packages/venia-ui/lib/components/ProductImageCarousel/thumbnail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ const Thumbnail = props => {

return (
<button
type="button"
className={isActive ? classes.rootSelected : classes.root}
onClick={handleClick}
aria-label={selectedItem}
Expand Down