Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3117::[PWA] display number of items in cart instead of quantities… #4150

Closed
wants to merge 6 commits into from

Conversation

glo82145
Copy link
Collaborator

… not working

Description

Preconditions
Leave only Yes or No as the answer

Issue is reproducible on the latest mainline, without Sample Data: Yes
JIRA was checked for similar/duplicated issues: Yes
GitHub project was checked: Yes
Merchdocs and Devdocs were checked: Yes
Double Check List L3 was checked: Yes
Steps to reproduce

Install PWA studio with [ 2.4-develop ]

Check the [ Display Cart Summary ] configuration from [ Store > Configuration > Sales > Checkout > My Cart Link > Display Cart Summary ]. The default value should available as [ Display item quantities ]

Create a simple product from the backend

Add 5 quantities to cart from the above product. The minicart will display like below. Which is correct with the default [ Display Cart Summary ] configuration.

Change the [ Display Cart Summary ] configuration to [ Display number of items in cart ]

Remove items from the shopping cart and again add 5 quantities from the same product

Check the mini-cart product count

Actual results
Minicart still displays [ 5 ].

Expected results
When we set [ Display Cart Summary ] configuration to [ Display number of items in cart ], it should not display the item quantity. The value it should display is [ 1 ], which is the number of unique items in the cart.

Related Issue

Closes #PWA-3117

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 27, 2023

Fails
🚫

node failed.

🚫

GraphQL queries did not pass. Make sure to execute yarn run validate-queries locally prior to committing.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/hooks/useCustomerWishlistSkus/__tests__/useCustomerWishlistSkus.spec.js
🚫

The following file(s) were not formatted with prettier. Make sure to execute yarn run prettier locally prior to committing.

packages/peregrine/lib/talons/Header/useCartTrigger.js
Messages
📖

Associated JIRA tickets: PWA-3117.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck


ERROR ON TASK: unitTests


ERROR ON TASK: validateQueries


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against afddae4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-concept version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants