Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3162-V3::Price filter change in sidebar #4164

Merged
merged 9 commits into from
Mar 20, 2024
Merged

PWA-3162-V3::Price filter change in sidebar #4164

merged 9 commits into from
Mar 20, 2024

Conversation

glo80771
Copy link
Contributor

Description

In the event that a different price filter is applied after a price filter is already applied, the query will only be for the first price filter, not the combination of the two.

This behavior might be interpreted as a bug but is actually a mis-implementation of the UI for the price filter which only allows a "range" ie {{

{ "from": "0", "to": "100" }
}}.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3162.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo80771 glo80771 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Sep 15, 2023
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 15, 2023

Messages
📖

Associated JIRA tickets: PWA-3162.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against baa04c9

@glo82145 glo82145 force-pushed the PWA-3162-V3 branch 5 times, most recently from 70509b7 to 78552e8 Compare March 20, 2024 13:39
@glo82145 glo82145 merged commit f58bed1 into develop Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants