Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3208::getting error on address page Unable to proceed checkout as… #4174

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

glo80771
Copy link
Contributor

@glo80771 glo80771 commented Oct 5, 2023

… guest/registered user with my local instance after pulling latest changes

Description

Steps to Reproduce

  1. Use local magento URL with prerequisites as backend server into .env of pwa
  2. Checkout to devlop server and install checkmo using command "yarn venia add -D @magento/venia-sample-payments-checkmo"
  3. now yarn install and yarn build and yarn stage:venia
  4. pickup URL and try to checkout with one of product
  5. observe if any error while clicking on shipping button from shipping address page

Expected Result

  1. User should be able to complete checkout without any issue
  2. User should be able to create user without any issues.

Actual Result

  1. getting error while clicking on shipping here on shipping address and unable to move to next screen
  2. Unable to create new user

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3208.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

… guest/registered user with my local instance after pulling latest changes
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3208.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 864a6df

@glo80771 glo80771 added the version: Patch This changeset includes backwards compatible bug fixes. label Oct 5, 2023
@glo82145
Copy link
Collaborator

glo82145 commented Oct 6, 2023

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 6, 2023

Successfully started codebuild job for lighthouse-desktop

@glo82145
Copy link
Collaborator

glo82145 commented Oct 6, 2023

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Oct 6, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145 glo82145 merged commit 76fbf76 into develop Oct 6, 2023
2 checks passed
@seyuf
Copy link

seyuf commented Sep 17, 2024

@glo05548 unfortunately this invalidates the previous commit fixing issues when a country region is not required e3a97e2

@seyuf
Copy link

seyuf commented Sep 17, 2024

Also this merge doesn't make any sense. You say you have issues with address on logged user. But the code you're modifying should only impact guests. Why is this merge without secondary review, anyway? Smells fishy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants