Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-2655 :Update magento-compatibility.js to indicate all dependencie… #4300

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

glo85315
Copy link
Contributor

…s and just not magento

Description

Update magento-compatibility.js to indicate all dependencies and just not magento

Related Issue

Closes: https://jira.corp.adobe.com/browse/PWA-2655

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 15, 2024

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-2655.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 295a805

@glo82145 glo82145 requested a review from glo42707 July 19, 2024 11:54
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please udpate below accordingly

var magentoVersion = '2.4.7-p1';

backend dependencies should aligned to only PWA core backed metapackages
"magento/module-upward-connector": "^2.0.4",
"magento/venia-sample-data": "^0.0.5",
"magento/venia-sample-data-ee": "^0.0.4",
"magento/pwa": "^0.7.2",
"magento/pwa-commerce": "^0.0.4"

@glo85315 glo85315 requested a review from glo42707 July 22, 2024 10:36
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@glo82145 glo82145 merged commit 14a19de into develop Jul 29, 2024
6 of 7 checks passed
@glo82145 glo82145 deleted the PWA-2655 branch July 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants