Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Conditions to Handle 404 redirect_code for Invalid Urls and Ad… #4357

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented Dec 5, 2024

…ding condition to handle Valid PWA URLs as well.

Description

Adding conditions to venia-ui/upward.yml veniaResponse object to handle 404 URLs as well as Valid PWA Responses.

Related Issue

Closes # https://jira.corp.adobe.com/browse/PWA-3386

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…ding condition to handle Valid PWA URLs as well.
@del15881 del15881 added version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. pkg:venia-ui labels Dec 5, 2024
@pwa-studio-bot
Copy link
Collaborator

Messages
📖

Associated JIRA tickets: PWA-3386.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 36fe04b

@del15881 del15881 requested a review from del22123 December 6, 2024 07:36
Copy link
Contributor

@glo42707 glo42707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: approved version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants