Pwa-3431::Fixed unique id,aria-label and disabled attribute warnings #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glo82145
added
the
version: Patch
magento-ct-gh-projects-svc
added
Progress: approved
and removed
Progress: review
labels
del15881
approved these changes
Feb 20, 2025
magento-ct-gh-projects-svc
added
Progress: approved
and removed
Progress: approved
labels
|
magento-ct-gh-projects-svc
added
Progress: approved
and removed
Progress: approved
labels
glo82145
added a commit
that referenced
this pull request
Mar 5, 2025
* adding release 14.1.0 change.log md * adding compatibility.js * v14.2.0-alpha.4 * Gomage v1 (#4393) * Removing gomage plugin * Removing gomage plugin * Update package.json * v14.2.0-alpha.5 * v14.2.0-alpha.6 * PWA remove gomage package (#4403) * PWA remove gomage package * PWA remove gomage package * Feature/venia sample payments cashondelivery from latest develop (#4401) * New Commit to Create NEW PR with Latest Develop * Fixing Prettier Issues * Adding workflow file to publish package * Updating Namespace to @adobe * Fixing Prettier Issues * Adding module to venia-concept/package.json * PWA Gomage * Adding Alpha versions * Removing Adobe Braintree Plugin from Package.json --------- Co-authored-by: Aanchal Pawar <97873570+glo82145@users.noreply.github.com> Co-authored-by: glo82145 <glo82145@adobe.com> * v14.2.0-alpha.7 * v14.2.0-alpha.8 * Update package.json_for Cashon Delivery (#4405) * Update package.json * Update package.json * Update package.json (#4406) * Update package.json (#4407) * v14.2.0-alpha.12 * Fixed unique id,aria-label and disabled attribute warnings (#4412) Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com> * Pwa 3433::adding ontouch (#4413) * Removing gomage plugin * PWA-3433:: adding ontouch * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * PWA-3433::adding touch option * v14.2.0-alpha.13 * Pwa 3437 (#4424) * Fixed place order and filter button issue * Fixed various console warnings in various pages * Fixed ariaLabel errors --------- Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com> * v14.2.0-alpha.14 * v14.2.0-beta.1 * v14.2.0-beta.2 * v14.2.0-beta.3 * Update publish-cod-to-npm.yml add release branch (#4426) * v14.2.0-beta4 * Removed npm yml (#4428) * v14.2.0-beta5 * v14.2.0 * v14.2.0 * Main 142 (#4440) * Fixing the searchPage Issue : setFilterOptions is not a function. (#4430) * Release notes/14.2.0 (#4429) * Removed npm yml * added release notes * added release notes * PWA-14.2.0- Changed log * v14.2.0-beta.6 * Merge conflict (#4433) * adding release 14.1.0 change.log md * adding compatibility.js * Removed npm yml * v14.2.0 * v14.2.0 --------- Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> * v14.2.0-beta.7 * Release 14.2.0 v2 (#4438) * adding release 14.1.0 change.log md * adding compatibility.js * v14.2.0 * v14.2.0 * merge conflict resolve --------- Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> * resolve merge conflicts --------- Co-authored-by: Ilesh Tiwari <del15881@adobe.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> * Main 142 v1 (#4441) * Removed npm yml * Fixing the searchPage Issue : setFilterOptions is not a function. (#4430) * Release notes/14.2.0 (#4429) * Removed npm yml * added release notes * added release notes * PWA-14.2.0- Changed log * v14.2.0-beta.6 * Merge conflict (#4433) * adding release 14.1.0 change.log md * adding compatibility.js * Removed npm yml * v14.2.0 * v14.2.0 --------- Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> * v14.2.0-beta.7 * Release 14.2.0 v2 (#4438) * adding release 14.1.0 change.log md * adding compatibility.js * v14.2.0 * v14.2.0 * merge conflict resolve --------- Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> --------- Co-authored-by: Ilesh Tiwari <del15881@adobe.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> * PWA-3430::added missing libraries (#4446) --------- Co-authored-by: arpit.khare <glo42707@adobe.com> Co-authored-by: magento-github-admin-beta <119524626+magento-github-admin-beta@users.noreply.github.com> Co-authored-by: devops-pwa-codebuild <magento-devops-github-pwa-int@adobe.com> Co-authored-by: Ilesh Tiwari <del15881@adobe.com> Co-authored-by: arpit khare <84493875+glo42707@users.noreply.github.com> Co-authored-by: Bharathidasan Elangovan <del22123@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed unique id, aria-label and disabled attribute warnings in several pages of PWA
Related Issue
Closes #PWA-3409
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist