Upgrades Storybook to major version 4

[supernova-at]

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will fix the current error that is causing Storybook to be unable to load any component stories:

Additional information

The reason Storybook errors out like this is that the storybook-readme addon that we are attempting to use wasn't listed as a dependency in package.json and therefore was not installed. couldn't be found.

I bumped Storybook (@storybook/react) and storybook-readme to major version 4 in pwa-studio and updated Storybook in packages/peregrine and packages/venia-concept to match.

Storybook now finds the storybook-readme addon at the higher level and therefore it does not need to be listed as a dev dependency in peregrine.

After this change, Storybook works as intended:

Potential Risk

Upgrading Storybook outside of the peregrine project may introduce some breakages.

I couldn't find anywhere else in pwa-studio or packages/venia-concept where Storybook was actually being used though, so I think the risk is none.

But with that being the case, should we remove the Storybook dependency from packages/venia-conept?

Note!

This PR is opened against the release/2.0 branch. If this is incorrect, kindly let me know and I'll point it to a different branch 🥂 .

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

[magento-cicd2]

All committers have signed the CLA.

[coveralls]

Coverage remained the same at 17.555% when pulling 01e7fc4 on supernova-at:storybook-error into 7a4cbf3 on magento-research:release/2.0.

[jimbo]

Thanks for your contribution! It would appear that storybook-readme is listed under devDependencies in the main repo's package file, though it's an earlier version. I'm surprised it doesn't work.

@zetlen Any idea why it wouldn't pick up the module from the main repo's node_modules directory?

[zetlen]

Super weird. It may be that the versions are incompatible--can you try upgrading storybook-readme?

[supernova-at]

It may be that the versions are incompatible

That was it!

I upgraded @storybook/react and storybook-readme to major version 4 and it works without having to install storybook-readme in peregrine.

I also bumped @storybook/react in peregrine and venia-concept to version 4 to match.

[supernova-at]

I updated the PR description with the new solution and outlined a potential risk.

[supernova-at]

For completeness

can you try upgrading storybook-readme?

I did try this and it did not work without also bumping @storybook/react.