Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categoryTile.js - item is not defined error #524

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

As described in #504, a fresh installation of PWA crashes after a Javascript error due to wrongly referenced item variable.

This PR is a:

[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[x] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

This PR changes the reference to item variable as suggested in the issue comments.

@magento-cicd2
Copy link

magento-cicd2 commented Nov 19, 2018

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Nov 19, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage remained the same at 17.555% when pulling c8fad8d on interactiv4:feature/fix-categorytile-item-is-not-defined into fd9b590 on magento-research:release/2.0.

@jimbo jimbo merged commit 408be99 into magento:release/2.0 Nov 19, 2018
@jimbo
Copy link
Contributor

jimbo commented Nov 19, 2018

Good catch! Thanks for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants